Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Q
quby-compiler
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
RoQua
quby-compiler
Merge requests
!22
Add validation for length of short_description and description
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Add validation for length of short_description and description
mv-validate-description
into
main
Overview
1
Commits
1
Pipelines
1
Changes
2
Merged
Per 29 mei 2024 gedeeld account, daarvoor marten
requested to merge
mv-validate-description
into
main
3 years ago
Overview
1
Commits
1
Pipelines
1
Changes
2
Expand
0
0
Merge request reports
Compare
main
main (base)
and
latest version
latest version
9fb71d31
1 commit,
3 years ago
2 files
+
33
−
9
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
lib/quby/compiler/services/definition_validator.rb
+
15
−
7
Options
@@ -15,8 +15,8 @@ module Quby
def
validate
(
definition
)
questionnaire
=
DSL
.
build_from_definition
(
definition
)
validate_metadata
(
questionnaire
)
validate_fields
(
questionnaire
)
validate_title
(
questionnaire
)
validate_questions
(
questionnaire
)
validate_scores
(
questionnaire
)
validate_table_edgecases
(
questionnaire
)
@@ -32,6 +32,20 @@ module Quby
backtrace:
exception
.
backtrace
[
0
..
20
]})
end
def
validate_metadata
(
questionnaire
)
if
questionnaire
.
title
.
blank?
fail
"Questionnaire title is missing."
end
if
questionnaire
.
short_description
&&
questionnaire
.
short_description
.
size
>
255
fail
"Questionnaire short_description is too long."
end
if
questionnaire
.
description
&&
questionnaire
.
description
.
size
>
255
fail
"Questionnaire description is too long."
end
end
def
validate_fields
(
questionnaire
)
questionnaire
.
fields
.
input_keys
.
find
{
|
k
|
!
k
.
is_a?
(
Symbol
)
}
@@ -41,12 +55,6 @@ module Quby
&
.
tap
{
|
k
|
fail
"Answer key
#{
k
}
is not a symbol"
}
end
def
validate_title
(
questionnaire
)
if
questionnaire
.
title
.
blank?
fail
"Questionnaire title is missing."
end
end
def
validate_questions
(
questionnaire
)
questionnaire
.
answer_keys
.
each
do
|
key
|
validate_key_format
(
key
)
Loading